[goodweather]

Haha…Good!
Here is the code

--
-- Called when a modulator value changes
-- @modulator   http://ctrlr.org/api/class_ctrlr_modulator.html
-- @modValue    new numeric value of the modulator
--
RenamePatch = function(modulator, modValue)

	if isPanelReady() then

		saCategories = StringArray()
		saCategories:set(0, String("Miscellaneous"))
		saCategories:set(1, String("Classic"))
		saCategories:set(2, String("Duo"))
		saCategories:set(3, String("Drone"))
		saCategories:set(4, String("Noise"))
		saCategories:set(5, String("Bass"))
		saCategories:set(6, String("Lead"))
		saCategories:set(7, String("Brass"))
		saCategories:set(8, String("Woodwind"))
		saCategories:set(9, String("Sound FX"))
		saCategories:set(10, String("Keys"))
		saCategories:set(11, String("Organs"))
		saCategories:set(12, String("Sync"))
		saCategories:set(13, String("Strings"))
		saCategories:set(14, String("Pads"))
		saCategories:set(15, String("Evolving"))
		saCategories:set(16, String("Distorted"))
		saCategories:set(17, String("Vox"))
		saCategories:set(18, String("Arp"))
		saCategories:set(19, String("Sequence"))
		saCategories:set(20, String("Percussion"))
		saCategories:set(21, String("User"))
		
		modalWindow = AlertWindow("\n\nModify patch name, category and description", " ", AlertWindow.InfoIcon)
		modalWindow:addButton("    OK    ", 1, KeyPress(KeyPress.returnKey),KeyPress())
		modalWindow:addButton("Cancel", 0, KeyPress(KeyPress.escapeKey),KeyPress())
		modalWindow:addTextEditor ("txtPatchName", "My patch", "Name", false)
		modalWindow:addComboBox ("cmbCategory", saCategories, "Category")
		modalWindow:addTextEditor ("txtPatchDescription", "This patch is fantastic...", "Description", false)
		modalWindow:addTextBlock ("Don't forget to save your changes afterwards with the Save button...")
		--modalWindow:setModalHandler(windowCallback)

		ret = modalWindow:runModalLoop()

		-- runModalLoop() returns a number that indicates what button was pressed to dismiss the window
		if ret == 0 then
			--console("Cancel")
		end
		if ret == 1 then
			--console("OK")
			textEditor = modalWindow:getTextEditor("txtPatchName"):getText()
			if textEditor ~= nil then
				txtPresetName:getComponent():setProperty("uiLabelText", textEditor, false)
			end
			if textEditor == "" then
				txtPresetName:getComponent():setProperty("uiLabelText", "Untitled Patch", false)
			end
		end
		modalWindow:setVisible (false)
	end

end

While looking for this I got something weird…
I had my Sub37 panel opened (it contains the code above) then I opened my test panel (the one I attached in the CC/NRPN feedback topic) and suddenly the Rename modal window opened by itself… Should definitively not happen as this is in another panel.
If needed I can post you the Sub37 panel. As Moog announced their editor, I will know simply try to finalize with what I discovered but I’m still lacking all NRPNs for the sequencer, I don’t know how to calculate the checksum so I cannot save files and I don’t know how to request a patch. At least it is doing what I wanted: load a patch and display all buttons positions and parameters.
Btw, I also adapted dasfaker’s enveloppe graph by making it fully flexible in terms of XY size. So, I could post it in a separate simple panel with some explanations.

I’ll work on a panel for my new DSI Pro2. Will use your bit packing stuff for sure…And at least for that one, everything is documented. So no more hours reverse engineering analysis of sysex as Moog don’t provide any Sub37 documentation.

[goodweather]

I’m using Ctrlr in standalone mode. Sub37 connected to USB. Sub37 appearing in list of Midi devices in Ctrlr.
Did you try the test panel with your Mopho or another synth?

Thx for the explanation about midi drivers being single client only.

[goodweather]

Hi Atom,
I have now made some tests…
I attach my simple test panel so you can have a look.
The device is a Moog Sub37. As I explained above, it outputs either in CC or in NRPN but not on both at the same time.
When output is set to CC: then I get the feedback on the 2 blue buttons (however, this was not working on the second button, I had to delete it and recreate it by doing a copy/paste of the first button – why?).
The issue is that with CC output, there are quite a lot of other Sub37 buttons that will not send feedback as they only send NRPN back. So, I would really prefer NRPN feedback.
When in NRPN, nothing is moving.
I attach the Ctrlr output (each time the 99,98,6,38 output by value) and input (=Sub37 output). Also from MidiOX. As you can see the Sub37 output is not as lean… you get several 38 (hex28) in a row then one 6 etc… 99 and 98 only when you change parameter.
Did you encounter same behaviour on your Moog devices?

Thx for helping and Merry Xmas to you and family…Dominique

Attachments:

You must be logged in to view attached files.

[goodweather]

Haha… Good news Atom!
I’ll check this further during the w-e and prepare some explanations/description of what I have. Sometimes I also don’t have feedback from CC messages as well.
I tested with a new empty panel just with 2 sliders. One in CC and one in NRPN. Each of them addresses a different EG parameter of the Sub37.
The Sub37 can send back in CC or in NRPN. So either one button or the other should move.
I have MidiOX. Are they specific messages you would like to get to be able to analyse what is not working?
I’m first starting the Moog then Ctrlr.

Something else, as I speak of MidiOX. MidiOX cannot start as long as Ctrlr is working (and I think it is the same in the other direction). Did you try this?

[goodweather]

Not sure if this will solve your issue, but the basics for NRPN messages is:

• you select a modulator (button)
• Under Midi, you select Multi as message type
• you enter your controller number
• In Multi message list, you click on the second button “Insert predefined” and select NRPN

Should work…

I will add this NRPN message procedure in my user guide http://ctrlr.org/forums/topic/ctrlr-step-by-step-guide/

[goodweather]

Thx a lot dasfaker! It works now.
It is exactly as you said. As I left the reset of bLoadingPreset in the main function, it was set back to 0 before the OnValueChange functions were triggered.
By putting it in the timer callback it gives the time of all modulators to perform their OnValueChange function.

Btw, I figured out the wave morphing function. Was pretty straightforward in fact. I’ll make it scalable next week (I have a long train trip so will have time to play with it).

[goodweather]

And thx Atom for having improved the Close panel behaviour (the “X” behaviour, indication of which panel closes)!

[goodweather]

Maybe found another small bug in the LUA editor: drag and drop of a method to reposition it doesn’t work. It works when moving methods from one folder to another folder. It doesn’t work when you try changing the order of methods within the same folder.

[goodweather]

Can you also verify the Lua editor -> Sort by name? Seems not to work.
I selected a folder (or also the top folder) then requested sort by name but nothing happened… Thx!

[goodweather]

Hi, I tested it and it works fine. Thx again for your tip!
I used the Panel modulator list to find the first modulator and add a call to my InitSub37Panel function stored somewhere else. I put in comment all assignments in the different modulators and it works thus good with central management from one function.

To understand further the behaviour (I like to understand things), it means thus that the code in assignValues is somewhat tested/”executed” before the user uses it and this occurs before even the panel loaded.
Right? Don’t you find this a bit “strange” or is this some Lua behaviour?

[goodweather]

Thx zeoka!
How do I find which modulator is the first one loaded? Is it the first one I created (the one with the lowest VST index)?
I could combine both ways: create a separate easy to maintain method to initiaze different things then call that method only once from the valueChange method of the first loaded modulator…

[goodweather]

Hi Puppeteer, thx for reply.
I have in fact already written a midiMessageReceived function including assignValue tough not implemented yet. My idea was to use it on dump receive but I missed its usage on NRPN message received! Good point, I’ll try this.
Now, even on CC working modulator, I don’t get my buttons turning accordingly.
I’ll try it on a simple dummy panel to analyse the behaviour.

[goodweather]

Hi, thx for your answer.
This was also my diagnostic… The method identified at “Called when panel has loaded” property being called before the actual load is finished…
I was expecting Atom to provide some support to this (probably classical) issue.

As I don’t know in advance what modulator will be first used by the user, at this stage I added my variable assignments in all methods… Not very good programming and I don’t like that but it is working.

So, any tip to improve this is still welcome!

Btw, where would I put a free script? How is its content recognized by other methods? Or is it simply enough the fact that it exists in the list of methods?

[goodweather]

Hi, some tips here:
– use the Save versioned command in the file menu. It will save the panel with a Major and Minor number and the date. You can set Major and Minor numbers yourself at panel level by modifying the values of their properties but when you save, the Minor is increased automatically (I described that in the Step by Step guide). Good way to find back a good panel. Please be aware that even when you save versioned, the panel you are workng on is still the original one.
– I had the same issues with preload… I solved it this way: in the users/your_user/AppData/Roaming/Ctrlr directory you will find a ctrlr.settings file. Make a copy of it in case of. Then edit the ctrlr.settings file with Notepad. Delete everything after I saw that after that tag it was the last panel details.
Save the file. Copy it into somehting like ctrlr.settings.empty.txt if you would need it another time. Restart Ctrlr and you will have an empty Ctrlr window…
I will add this tip in my guide…

[goodweather]

Hi, some feedback on the Sub37 panel…
Very good progress:

• enveloppe graph display added (based on dasfaker’s graphs but improved – flexible size – and adapted to DAHDSR parameters)
• selection of Filter or Amplifier EG graph display
• all buttons are now done, including 4 and 6 positions ones
• direct access buttons for EG parameters using the Shift button on the synth
• name and actual value of parameter is displayed in the “screen”
• explanation of the parameter from the manual is also displayed
• all leds are acting according to buttons
• series of radio buttons for the bank selection
• series of radio buttons for the preset selection
• load and save .syx file buttons (no code yet)

Ongoing:

• reverse engineering of the .syx dump (no dcumentation availabel from Moog, time consuming but I already succeeded to understand the 4-6-6 coding of each parameter, still don’t understand some checksum calculation at the end of the dump
• will implement the functions to open and save parameters in a .syx file
• continue to copy/paste explanations from the manual for each parameter
• implement the preset change Midi message

…and many other ideas for the future (arp and seq editor, double modulation matrix, display of OSC wave shapes…)…

Attachments:

You must be logged in to view attached files.

[goodweather]

No idea from anyone?

[goodweather]

Hi Atom, Thanks for this build!
Hiding menu can indeed be usefull.
I tested the “Midi devices refresh” (thx to have implemented this so quickly :)) but it doesn’t work fully at least for me and my Sub37.
The behaviour I have is the following:
– Ctrlr started, Sub37 panel open, Sub37 synth OFF
– Sub37 synth ON, not appearing in the list of Midi devices
– Refresh from the menu
– Sub37 device is appearing but with unhappy face
– Closing panel (not Ctrlr) and re-opening it then Happy face
So, probably something missing to have directly the happy face…

Do you have the same behaviour with your synths?

Then different small remarks:

• uiTabs background image layout: centred should be centered
• uiTabs “Content background colour”
• Everywhere: color or colour (US vs British English )
• uiTabs – Tabs orientation: TabsAtLeft
• Naming agreement: bubble or tooltip? At modulator level properties are referring to Bubble while at Panel level it is Tooltip. Is this the same object or something different?
• Bubble: Name text justification
• Change LUA to Lua in Ctrlr menu and all other places (according to official Lua site, it should be Lua and not LUA)

Once again, thx for having made this great tool!

[goodweather]

Hi,
you must have looked to the in DEV version of the step by step guide.
The released version is only in PDF.
It is at http://ctrlr.org/forums/topic/ctrlr-step-by-step-guide/
I’m now adding a few things to make a 1.3.
And I’m concentrating on my Sub37 panel (but need to do sysex dump reverse engineering / decode which is taking lot of evening time)…

[goodweather]

Thank you dasfaker!
I tested the Ctrl+R on opening and it works fine. Also getting the warning window which is good. I will add that in the Step by Step guide.

I did the Save Ctrlr State with no panel open. Where is it saved? In Appdata->Roaming->Ctrlr? Under which name? How to restore from a previous state?
Is it the ctrlr.settings file that I should then keep safe as a copy in case of?

Before you wrote your answer, I had opened the ctrlr.settings file, saw my panel in there, removed it to keep only the first part and then re-opened Ctrlr and this has been working fine. So, I’m now keeping this “empty” file.

Thx for clarifying my questions above about the Save state. I’ll also add that in the Step by Step guide.

[goodweather]

Hi!
Please look at my Ctrlr Step by Step Guide 1.2 (use Search or go to the News and Release area of the forum). I explained this a bit.
Best way to learn is to download panels using tabs. I looked at the Minitaur one for example.
Good luck…

[Author]

Posts